Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename retype to cast, overriding old cast. Deprecate and remove retype functions. #33075

Closed
4 of 6 tasks
lrhn opened this issue May 8, 2018 · 15 comments
Closed
4 of 6 tasks

Rename retype to cast, overriding old cast. Deprecate and remove retype functions. #33075

lrhn opened this issue May 8, 2018 · 15 comments
Assignees
@lrhn
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-core
Projects
2.0 language

Comments

@lrhn
Copy link
Member

lrhn commented May 8, 2018 •
edited by dgrove

The cast and retype methods on numerous types are confusing and removing cast will make the API better for users. We will reuse the cast name for the current retype behavior.

Steps:

  • Change cast to work as retype (fails no tests in the SDK, five tests in google3) and deprecate retype. (CL)
  • Roll into google3.
  • Change all calls to retype to call cast instead after rolling in the change.
  • Update packages to use cast instead of retype.
  • Remove retype from SDK.
  • Remove retype from packages that manually implement retype on the interfaces.
@lrhn lrhn added this to the Dart2Beta4 milestone May 8, 2018
@anders-sandholm anders-sandholm added area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-core labels May 9, 2018
@zoechi zoechi mentioned this issue May 15, 2018
Closed
@leafpetersen
Copy link
Member

This is in process. The initial change has landed, waiting on a roll.

@dgrove dgrove modified the milestones: Dart2Beta4, Dart2Stable May 17, 2018
@dgrove
Copy link
Contributor

dgrove commented May 18, 2018

The roll has now occurred.

@leafpetersen leafpetersen added this to Core Libraries in 2.0 language May 24, 2018
@leafpetersen
Copy link
Member

@lrhn How is this going?

@lrhn
Copy link
Member Author

lrhn commented May 26, 2018

I have two remaining CL's out that I need land in google code, and one in Flutter, then neither should be using retype any more (or at least be resistant to it being removed).
I have made a PR for package:observable, so it too should be good. I still have to check if there are any other packages affected.

@dgrove
Copy link
Contributor

dgrove commented Jun 5, 2018

Any further updates, @lrhn ?

dart-bot pushed a commit that referenced this issue Jun 12, 2018
@lrhn
Remove the retype method.
0b91676 
See #33075.

Bug: http://dartbug.com/33075
Change-Id: I1ee2f587afbc672dd08ac61ac003bbdc85bb95e2
Reviewed-on: https://dart-review.googlesource.com/59091
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
@lrhn
Copy link
Member Author

lrhn commented Jun 18, 2018

Since retype has been removed from the SDK, packages are now forced to be updated, and it seems we are on-track for that within this week.

Going back and removing the, now unnecessary, retype declarations from packages can be handled on a per-package basis.

@mit-mit
Copy link
Member

mit-mit commented Jul 9, 2018

The work here is believed to be complete; just need to double-check that this was rolled to google3

@mit-mit
Copy link
Member

mit-mit commented Jul 9, 2018

@whesse can you help confirm that this is in google3?

@natebosch
Copy link
Member

Remove retype from packages that manually implement retype on the interfaces.

I haven't seen this effort - are we planning on pushing it to package owners? I wouldn't consider it blocking for Dart2Stable if that is all that is remaining.

@whesse
Copy link
Contributor

whesse commented Jul 10, 2018

I don't know anything about this, or how to find out which SDK and third_party package versions are in Google3.

@mit-mit
Copy link
Member

mit-mit commented Jul 10, 2018

@srawlins any chance you know?

@srawlins
Copy link
Member

No, but I suspect the following packages: collection, observable, and quiver. I don't know of any internal manual implementations.

@dgrove
Copy link
Contributor

dgrove commented Jul 10, 2018

The SDK which removes retype hasn't yet landed in google3.

@JekCharlsonYu JekCharlsonYu added the P1 A high priority bug; for example, a single project is unusable or has many test failures label Jul 12, 2018
@dgrove
Copy link
Contributor

dgrove commented Jul 13, 2018

Internal work here is done.

@dgrove
Copy link
Contributor

dgrove commented Jul 13, 2018

@mit-mit lowering priority, and removing from Dart2Stable (if you disagree, please add back).

@dgrove dgrove removed the P1 A high priority bug; for example, a single project is unusable or has many test failures label Jul 13, 2018
@dgrove dgrove removed this from the Dart2Stable milestone Jul 13, 2018
@srawlins srawlins removed their assignment Jul 13, 2018
@lrhn lrhn closed this as completed Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lrhn lrhn

Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-core
Projects
No open projects
2.0 language
  
Core Libraries
Milestone
No milestone
Development

No branches or pull requests
9 participants
@srawlins @dgrove @anders-sandholm @lrhn @whesse @natebosch @leafpetersen @mit-mit @JekCharlsonYu