Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coreimpl inconsistent between different Dart implementations #949

Closed
jmesserly opened this issue Dec 22, 2011 · 4 comments
Closed

coreimpl inconsistent between different Dart implementations #949

jmesserly opened this issue Dec 22, 2011 · 4 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-obsolete Closed as the reported issue is no longer relevant

Comments

@jmesserly
Copy link

coreimpl is largely provided by the implementations (dartc, vm, frog), there's no check that they are all exposing the same coreimpl interface. And right now it doesn't look very consistent between the three. Just to take List as an example: VM has ObjectArray/GrowableObject array, DartC has ListImplementation, and Frog has ListFactory (expect a fix soon to call it ListImplementation).

One idea here: define all the interfaces in coreimpl, and implementation specific classes should be marked with a leading underscore so users don't depend on them.
@ghost
Copy link

ghost commented Dec 22, 2011

The "coreimpl" is not supposed to be a public interface, but rather (varying) implementations of core interfaces.

(Originally "coreimpl" was not accessible to user programs at all. While some similarity issues can be improved, the implementations will never match.)

The user programs should program to the interfaces of "core" library not to "coreimpl". If there are "coreimpl" interfaces that seems to belong to core library, then we should file individual issues.

@jmesserly
Copy link
Author

Whoa. If that's true I don't see why coreimpl can be imported by user code at all.

Maybe the issue then is why so much useful, not implementation specific stuff is in coreimpl instead of corelib, like concrete collection implementations (hash map, splay tree, etc): http://dart.googlecode.com/svn/branches/bleeding_edge/dart/corelib/src/implementation/

Or useful things under {runtime|frog|compiler}/lib like: Collections, ByteBuffer, ImmutableArray/Map (what if I want to create one from values that aren't compile time const?) the actual List implementations, etc...

@floitschG
Copy link
Contributor

This bug doesn't apply anymore.
Coreimpl has been removed in experimental/lib_v2.

Added AssumedStale label.

@jmesserly
Copy link
Author

Agreed. This does not apply anymore.

There's still an open issue about extending List's default implementation, which is tracked in this bug:
http://code.google.com/p/dart/issues/detail?id=2600

@jmesserly jmesserly added Type-Defect area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-obsolete Closed as the reported issue is no longer relevant labels Dec 21, 2012
copybara-service bot pushed a commit that referenced this issue May 30, 2023
@jcollins-g
[deps] rev dartdoc, http, lints, logging, tools, webdev
2a56918 
Revisions updated by `dart tools/rev_sdk_deps.dart`.  rev_sdk_deps is changed to default to `main` if no branch is found, as `origin` doesn't seem to work for impacted repos (e.g. csslib).

dartdoc (https://github.com/dart-lang/dartdoc/compare/1d94484..950898f):
  950898f5  Tue May 30 11:18:38 2023 -0700  Janice Collins  Reintroduce remote linking file type assumption (#3425)
  ef552992  Tue May 30 09:49:16 2023 -0700  Sam Rawlins  Refactor search ranking (#3424)

http (https://github.com/dart-lang/http/compare/8a4a4a6..18a43a2):
  18a43a2  Tue May 30 09:44:24 2023 -0700  Brian Quinlan  Fix the failing cupertino_http tests (#949)

lints (https://github.com/dart-lang/lints/compare/4236c43..edc28ed):
  edc28ed  Tue May 30 11:56:29 2023 -0500  Parker Lougheed  Add topics to the pubspec file (#122)

logging (https://github.com/dart-lang/logging/compare/7ba155a..f2fe2ac):
  f2fe2ac  Tue May 23 15:01:13 2023 -0700  Jacob MacDonald  prep for release (#140)
  ce41605  Mon May 22 10:14:28 2023 -0700  Devon Carew  blast_repo fixes (#142)

tools (https://github.com/dart-lang/tools/compare/b90a7e8..d723a55):
  d723a55  Tue May 30 11:02:27 2023 -0700  Devon Carew  Update pull_request_label.yml (#107)

webdev (https://github.com/dart-lang/webdev/compare/4b69f1d..d442fa8):
  d442fa89  Tue May 30 14:36:53 2023 -0400  Anna Gringauze  Check for new events more often in batched stream. (#2123)

Change-Id: I9e8905363ee51462529341bfba268504336d90e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/306314
Auto-Submit: Janice Collins <jcollins@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-obsolete Closed as the reported issue is no longer relevant
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmesserly @floitschG