Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move DateTime's month and weekday constants to a pub package #9346

Closed
DartBot opened this issue Mar 21, 2013 · 5 comments
Closed

Move DateTime's month and weekday constants to a pub package #9346

DartBot opened this issue Mar 21, 2013 · 5 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-not-planned Closed as we don't intend to take action on the reported issue

Comments

@DartBot
Copy link

DartBot commented Mar 21, 2013

This issue was originally filed by @seaneagan

See http://pub.dartlang.org/packages/calendar_constants
@DartBot
Copy link
Author

DartBot commented Mar 21, 2013

This comment was originally written by devol...@gmail.com

I'm 100% behind this. There's something.. phpish.. about the way those constants look now.

@madsager
Copy link
Contributor

Added Area-Library, Triaged labels.

@DartBot
Copy link
Author

DartBot commented Mar 22, 2013

This comment was originally written by george.moscho...@gmail.com

Not sure if it should be a separate pub package. But I don't like the abbreviations either.

@DartBot
Copy link
Author

DartBot commented Mar 22, 2013

This comment was originally written by pjpire...@gmail.com

I agree with #­3. I just don't like the abbreviations but I think this should be available in Dart itself.

@floitschG
Copy link
Contributor

We won't create a new pub-package (although we are happy with external packages as long as they use the same constants).
However we will rename them to non-abbreviated names.

Reasoning: we want DateTime to be in dart:core, but don't want to pollute the namespace with too many variables/constants.

See issue #9441 for the renaming change.

Added NotPlanned label.

@DartBot DartBot added Type-Defect area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-not-planned Closed as we don't intend to take action on the reported issue labels Mar 26, 2013
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-not-planned Closed as we don't intend to take action on the reported issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@madsager @floitschG @DartBot