Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dart2js: mouse input broken (Y = X) in Chrome & Opera #9261

Closed
DartBot opened this issue Mar 19, 2013 · 5 comments
Closed

dart2js: mouse input broken (Y = X) in Chrome & Opera #9261

DartBot opened this issue Mar 19, 2013 · 5 comments
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures web-libraries Issues impacting dart:html, etc., libraries

Comments

@DartBot
Copy link

DartBot commented Mar 19, 2013

This issue was originally filed by googlegroups...@kaioa.com

With r20157, when running a to-js-compiled application in Chrome or Opera, Y is always set to the same value as X.

Changing offsetX to offset.x and offsetY to offset.y did not help. Omitting the --minify flag also didn't help.

Running the Dart code directly in Dartium still works fine. Interestingly, the generated code does work fine in Firefox.
@kasperl
Copy link

kasperl commented Mar 19, 2013

Since the code works fine in Firefox, I'm assuming this is HTML library issue.

Removed Priority-Medium label.
Added Priority-High, Area-HTML, Triaged labels.

@DartBot
Copy link
Author

DartBot commented Mar 19, 2013

This comment was originally written by googlegroups...@kaioa.com

Found the typo:

https://code.google.com/p/dart/codesearch#dart/trunk/dart/tools/dom/templates/html/dart2js/impl_MouseEvent.darttemplate&q=var%20y%20=%20JS%5C('int',%20'%23.offsetX',%20this%5C)&sq=package:dart&l=63

@floitschG
Copy link
Contributor

Thanks!
Fixed in r20205.

Added Fixed label.

@DartBot
Copy link
Author

DartBot commented Mar 19, 2013

This comment was originally written by kholbr...@sonardesign.com

Please escalate for a new build.
This bug prevents us from updating.

@blois
Copy link
Contributor

blois commented Mar 19, 2013

A workaround is to implicitly use the polyfill that FF uses:

getMouseEventOffset(MouseEvent e) {
  return (e.client - e.target.getBoundingClientRect().topLeft;
}

@DartBot DartBot added Type-Defect P1 A high priority bug; for example, a single project is unusable or has many test failures web-libraries Issues impacting dart:html, etc., libraries labels Mar 19, 2013
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures web-libraries Issues impacting dart:html, etc., libraries
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@blois @kasperl @floitschG @DartBot