Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide sync measurement methods within a special requestMeasurementFrame callback #838

Closed
jacob314 opened this issue Dec 13, 2011 · 10 comments
Closed

Provide sync measurement methods within a special requestMeasurementFrame callback #838

jacob314 opened this issue Dec 13, 2011 · 10 comments
Labels
web-libraries Issues impacting dart:html, etc., libraries
Milestone
M2

Comments

@jacob314
Copy link
Member

Within this callback, any calls mutating the DOM should trigger an assert in dev mode.
@vsmenon
Copy link
Member

vsmenon commented Apr 12, 2012

Removed Area-UI label.
Added Area-DOM label.

@vsmenon
Copy link
Member

vsmenon commented Jun 22, 2012

Jacob: is this still an open?

Added this to the M1 milestone.
Added NeedsInfo label.

@jmesserly
Copy link

Yes. Though I think we were considering removal/redesign of async measurement?

@iposva-google
Copy link
Contributor

Removed Area-DOM label.
Added Area-HTML label.

@vsmenon
Copy link
Member

vsmenon commented Aug 17, 2012

Removed the owner.
Added Triaged label.

@vsmenon
Copy link
Member

vsmenon commented Aug 23, 2012

Removed this from the M1 milestone.
Added this to the M2 milestone.

@jmesserly
Copy link

I don't know if we have this tracked in another bug or not, but having a nice "microtask" API to queue something that will happen before paint would be really useful as a general feature.

@DartBot
Copy link

DartBot commented Oct 3, 2012

This comment was originally written by mikeeber...@gmail.com

I am definitely interested in a "sync" version. I have implemented some code that is definitely overly-complex due to how the async version makes my application-execution-path utterly nonsensical without an equally strange workaround that requires me to put a callback into the future-based-async routine (current version) that, only on the first completion, actually launches my application through my desired-execution-path via what is essentially a new "main()" entry point provided in the callback. ughhh.

@blois
Copy link
Contributor

blois commented Oct 3, 2012

For a microtask API- you should be able to use window.requestLayoutFrame for this purpose.

I do find it a bit odd though that layout effectively runs at a higher priority than animation though, so we may want to consider some name changes here.

@blois
Copy link
Contributor

blois commented Oct 8, 2012

The synchronous measurement APIs have been unhidden, no need to use requestMeasurementFrame.

Added Fixed label.

@jacob314 jacob314 added Type-Defect web-libraries Issues impacting dart:html, etc., libraries labels Oct 8, 2012
@jacob314 jacob314 added this to the M2 milestone Oct 8, 2012
copybara-service bot pushed a commit that referenced this issue Jun 9, 2023
@devoncarew
[deps] rev protobuf, test, webdev
ca2adbc 
Revisions updated by `dart tools/rev_sdk_deps.dart`.

protobuf (https://github.com/dart-lang/protobuf/compare/da6953c..edf8e92):
  edf8e92  2023-06-09  Ömer Sinan Ağacan  Fix parsing negative JSON values for uint32 fields (#839)
  2931b2e  2023-06-09  Ömer Sinan Ağacan  Add PR links to recent CHANGELOG entries (#838)

test (https://github.com/dart-lang/test/compare/7a6c98d..e7ae613):
  e7ae6139  2023-06-08  Nate Bosch  Remove redundant type checks (#2031)

webdev (https://github.com/dart-lang/webdev/compare/3d7f546..a6d761d):
  a6d761d8  2023-06-08  Elliott Brooks  Remove tabs permission (#2136)
  b02b344e  2023-06-08  Elliott Brooks  Catch `WipError` on calls to resume and map to appropriate RPC error code (#2134)

Change-Id: I58b111a433cef76a501c959f33db4e5463a34c60
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/308380
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
web-libraries Issues impacting dart:html, etc., libraries
Projects
None yet
Milestone
M2
Development

No branches or pull requests
6 participants
@jmesserly @jacob314 @vsmenon @blois @iposva-google @DartBot