Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

corelib: instead of renaming 'map' to 'mappedBy' consider 'select' (nice alignment with .NET since filter is renamed where) #6739

Closed
kevmoo opened this issue Nov 15, 2012 · 5 comments
Closed

corelib: instead of renaming 'map' to 'mappedBy' consider 'select' (nice alignment with .NET since filter is renamed where) #6739

kevmoo opened this issue Nov 15, 2012 · 5 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-collection

Comments

@kevmoo
Copy link
Member

kevmoo commented Nov 15, 2012

Looking at the change in the lib_v2 branch, r14908

filter/map/reduce all align nicely with Python.

where/select/aggregate all align nicely with .NET/C#/Linq (and indirectly SQL)

I've never seen 'mappedBy' used in this context. A quick search turns up references to hibernate.

Here's a vote for clean alignment with existing implementations to minimize confusion.

A subjective suggestion, I know, but I wanted to go on the record. (as a .NET guy)
@madsager
Copy link
Contributor

cc @floitschG.
Added Area-Library, Library-Collections, Triaged labels.

@dgrove
Copy link
Contributor

dgrove commented Jan 11, 2013

Removed Library-Collections label.
Added Library-Collection label.

@floitschG
Copy link
Contributor

Fixed in r17918.

Added Fixed label.

@kevmoo
Copy link
Member Author

kevmoo commented Jan 31, 2013

...I don't knew if I'd consider this "Fixed"...but certainly "addressed".

:-)

@munificent
Copy link
Member

For what it's worth, I think select() would have been the wrong choice here. I discussed it with Florian a bit. One big problem is that "select" in Ruby is equivalent to filter, not map. So people coming from SQL would understand select(), people coming from other languages would have no idea what it does, and people coming from Ruby would think it does something completely different.

@kevmoo kevmoo added Type-Defect area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-collection labels Jan 31, 2013
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-collection
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kevmoo @munificent @dgrove @madsager @floitschG