Suggest false above other results when autocompleting a bool setter
#37907
Comments
ghost
mentioned this issue
pq
added
area-analyzer
|
I'm no longer seeing this?
/cc @jwren |
|
Do we know that what you're trying there triggered the same behavior that the OP saw? I tried a couple of variations that are different from what you're trying and see the same behavior, so it's likely that it's fixed. But without reproduction steps it's hard to know for sure. |
|
You make a good point. I don't know. I tried a few variations myself and couldn't reproduce (though I'm confident I used to be able to) 🤔 |
|
Then I'm going to close this and ask that the OP re-open it (or ask us to), with a reproduction case, if it doesn't work after the next release. |
|
(FWIW: a test of one variation is in https://dart-review.googlesource.com/c/sdk/+/135961; if the issue recurs we should add more test cases there.) |
|
I'll try to repro and report back |
|
Ha, so false was fine. It was at the stop of the list after typing So I tried true with
My project shouldn't even allow |
|
The reason why |
|
Does it not take into account types? Element.tr() doesn't return something that would be assignable to a boolean. |
|
AFAIK it does, but this weigher is lower than the exact match one. Type a prefix so that both Type The logic, I think, is that even though the exact match might be not the type you are looking for, you might call something one it, to get the necessary type, e.g. |
|
Right, kk. |
|
I believe that this was fixed by https://dart-review.googlesource.com/c/sdk/+/184861 (modulo any re-ordering done by IntelliJ). |
@MisterJimson commented on Aug 19, 2019, 4:10 PM UTC:
Steps to Reproduce
Set a bool and trigger autocomplete after typing "f";
False should be the first item returned, instead of
bool.fromEnvironmentVersion info
[✓] Flutter (Channel stable, v1.7.8+hotfix.4, on Mac OS X 10.14.6 18G87, locale en-CA)
• Flutter version 1.7.8+hotfix.4 at /Users/jrai/dev/flutter
• Framework revision 20e59316b8 (5 weeks ago), 2019-07-18 20:04:33 -0700
• Engine revision fee001c93f
• Dart version 2.4.0
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
• Android SDK at /Users/jrai/Library/Android/sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-28, build-tools 28.0.3
• ANDROID_HOME = /Users/jrai/Library/Android/sdk
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 10.3)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 10.3, Build version 10G8
• CocoaPods version 1.7.2
[✓] iOS tools - develop for iOS devices
• ios-deploy 1.9.4
[✓] Android Studio (version 3.4)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 38.2.1
• Dart plugin version 183.6270
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
[✓] VS Code (version 1.37.0)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.3.0
[✓] Connected device (1 available)
• iPad Air 2 • 7250467B-9C77-4B88-B47C-35C154EEE5C2 • ios • com.apple.CoreSimulator.SimRuntime.iOS-12-4 (simulator)
• No issues found!
This issue was moved by pq from flutter/flutter-intellij#3799.
The text was updated successfully, but these errors were encountered: