Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert old supermixin tests to use real mixin declarations #34781

Closed
bwilkerson opened this issue Oct 13, 2018 · 2 comments
Closed

Convert old supermixin tests to use real mixin declarations #34781

bwilkerson opened this issue Oct 13, 2018 · 2 comments
Assignees
@lrhn
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).

Comments

@bwilkerson
Copy link
Member

The tests that need to be converted are the ones that are marked as "Skip" in this CL: https://dart-review.googlesource.com/c/sdk/+/79475.
@bwilkerson bwilkerson added the area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). label Oct 13, 2018
@bwilkerson bwilkerson mentioned this issue Oct 13, 2018
Closed
@lrhn lrhn assigned lrhn and unassigned leafpetersen Oct 15, 2018
@lrhn
Copy link
Member

lrhn commented Oct 16, 2018

CL: https://dart-review.googlesource.com/c/sdk/+/79700

Seems analyzer does not accept super-invocations in mixins derived from classes with Object as super-class.

@lrhn
Copy link
Member

lrhn commented Oct 23, 2018

Fixed by landing the above CL.

@lrhn lrhn closed this as completed Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lrhn lrhn

Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lrhn @bwilkerson @leafpetersen