Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CFE is angry about type variables in overridden method #33971

Closed
srawlins opened this issue Jul 24, 2018 · 2 comments
Closed

CFE is angry about type variables in overridden method #33971

srawlins opened this issue Jul 24, 2018 · 2 comments
Assignees
@chloestefantsova
Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues. P1 A high priority bug; for example, a single project is unusable or has many test failures
Milestone
Dart2Stable

Comments

@srawlins
Copy link
Member

This did not produce an error in 2.0.0-dev.68.0, but produces an error in 2.0.0-dev.69.2:

class Table<T extends Table<T>> {}

abstract class ColumnVisitor {
  void visitColumn<T extends Table<T>>();
}

class FilterBuilder implements ColumnVisitor {
  @override
  void visitColumn<T extends Table<T>>() {}
}

void main() {}
$ dart a.dart 
a.dart:9:8: Error: Declared type variables of 'FilterBuilder::visitColumn' doesn't match those on overridden method 'ColumnVisitor::visitColumn'.
  void visitColumn<T extends Table<T>>() {}
       ^

I don't see why the type variables wouldn't match...
@srawlins srawlins added P1 A high priority bug; for example, a single project is unusable or has many test failures area-front-end Use area-front-end for front end / CFE / kernel format related issues. labels Jul 24, 2018
@srawlins srawlins added this to the Dart2Stable milestone Jul 24, 2018
@vsmenon
Copy link
Member

vsmenon commented Jul 24, 2018

@stefantsov - can you please take a look? Looks like this is blocking the internal roll.

@chloestefantsova
Copy link
Contributor

Thanks for spotting this! CL 66560 is supposed to contain a fix.

@chloestefantsova chloestefantsova mentioned this issue Jul 25, 2018
Closed
dart-bot pushed a commit that referenced this issue Jul 25, 2018
@whesse
[fasta] Fix override checks for generic methods
147c150 
Fixes #33971.

Bug: http://dartbug.com/33971
Change-Id: I66ee51ccfa0b8109602593f04961b58bf589d0be
Reviewed-on: https://dart-review.googlesource.com/66560
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chloestefantsova chloestefantsova

Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues. P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Milestone
Dart2Stable
Development

No branches or pull requests
3 participants
@srawlins @chloestefantsova @vsmenon