Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onError callback in runZoned should allow optional arguments #33589

Closed
natebosch opened this issue Jun 22, 2018 · 1 comment
Closed

onError callback in runZoned should allow optional arguments #33589

natebosch opened this issue Jun 22, 2018 · 1 comment
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-async type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@natebosch
Copy link
Member

runZoned with an onError callback matching void Function(Object, [StackTrace]) used to get the stack trace, after 315a186#diff-12fb606dfa5b73b9715d30ae9fa63c32R1471 it no longer does.

We used to check for the binary callback first which would match with an optional second argument.

This is causing a failure in package:async tests.

cc @lrhn
@lrhn lrhn added area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-async type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Jun 25, 2018
@lrhn
Copy link
Member

lrhn commented Jun 25, 2018 •
edited

That sounds like a bug. It should still be checking the binary callback first.

... and we don't, so my bad. Fixing this ASAP.

This was referenced Jul 9, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-async type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lrhn @natebosch