Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mixin derived from classes with synthetic noSuchMethod forwarders should not include those. #33380

Closed
lrhn opened this issue Jun 7, 2018 · 2 comments
Closed

Mixin derived from classes with synthetic noSuchMethod forwarders should not include those. #33380

lrhn opened this issue Jun 7, 2018 · 2 comments
Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues.

Comments

@lrhn
Copy link
Member

lrhn commented Jun 7, 2018

The mixin application derived from a class which introduces synthetic noSuchMethod forwarders should not include those forwarders.

(This is a reversion of a previous decision, but we decided that this is marginally better behavior for a very obscure corner case because anyone depending on the forwarding methods being there will not be able to move to the expected mixin declaration. So, it's for forward compatibility).
@lrhn lrhn added the area-front-end Use area-front-end for front end / CFE / kernel format related issues. label Jun 7, 2018
@srawlins srawlins mentioned this issue Jun 14, 2018
Closed
This was referenced Jun 18, 2018
Closed
Closed
@dgrove
Copy link
Contributor

dgrove commented Jun 20, 2018 •
edited

Should this be closed now that https://dart-review.googlesource.com/60924 has landed?

@chloestefantsova chloestefantsova mentioned this issue Jun 21, 2018
Closed
@chloestefantsova
Copy link
Contributor

There was one more missing piece of the puzzle: 71ac67a. Now I believe it can be closed in case it was the issue for the CFE. Note that there's also a related issue for Analyzer: #33553.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-front-end Use area-front-end for front end / CFE / kernel format related issues.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chloestefantsova @dgrove @lrhn