New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotations are not inherited from mixins with --preview-dart-2 #33099
Comments
This works around #33099 R=brianwilkerson@google.com Change-Id: Idfada538b30fe6d8cce2d23112787522e5d19521 Reviewed-on: https://dart-review.googlesource.com/54705 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
This was reverted because it broke some Flutter tests. I am investigating. |
This same code was used to generate noSuchMethod forwarders, and so the change to always copy annotations caused nSM forwarders to have the same annotations as the method they represented (they should not, according to the language team). This revealed a bug: the nSM forwarders would be marked external if the method they represented was (but they are not external). This was relatively benign until they had a corresponding We will fix the bugs in nSM forwarders and then reland the fix for this issue. |
@stefantsov will implement removing annotations (including parameter annotations) from NSM forwarders (and clearing the external bit). He'll land a fix for this issue at the same time. |
This reverts commit 242bc34. R=brianwilkerson@google.com Bug: #33099 Change-Id: I8a1b24926072fe64e3ab73d38a1fa73695237fc4 Reviewed-on: https://dart-review.googlesource.com/57701 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
This code prints
true
without--preview-dart-2
and printsfalse
with it.@bwilkerson
The text was updated successfully, but these errors were encountered: