This comment was originally written by ladicek@gmail.com

Quick note about tests: I'm not familliar with Dart testing, and I can't currently imagine a way to test this feature. If I'd run a testing Dart script from Dart test, then it would never be attached to a terminal, so I could only test a half of it. But maybe that's better than nothing, so I'll take a look at it.

This comment was originally written by ladicek@gmail.com

OK, adding second version of the patch with a simple test.

Attachment:
0001-added-an-isTerminal-function-to-dart-io-for-testing-.patch (6.07 KB)

cc @sgjesse.
cc @madsager.
Added Area-IO, Triaged labels.

In stdio.dart we already have the function _getStdioHandleType that calls a native function to determine whether a file descriptor is bound to a terminal, pipe, file or socket. We should leverage that either by adding a general function to get the type of a stream

class StreamType {
  static final StreamType TERMINAL = const StreamType("TERMINAL");
  static final StreamType PIPE = const StreamType("PIPE");
  static final StreamType FILE = const StreamType("FILE");
  static final StreamType SOCKET = const StreamType("SOCKET");
  const StreamType(String this.name);
  final String name;
}

StreamType streamType(stream) {
}

or add a type getter to the InputStream and OutputStream interfaces.

The problem with the general function is that it will not be able to handle new stream types. E.g we already have the list input and output streams. If we have the type getter on the stream interfaces it would be possible to add new types, e.g.

// List stream implementation file.

static final StreamType _listStreamType = const StreamType("LIST");

class ListInputStream implements InputStream {

  ...

  StreamType type() => _listStreamType;

  ...
}

Set owner to @sgjesse.
Removed Type-Defect label.
Added Type-Enhancement, Accepted labels.

This comment was originally written by ladicek@gmail.com

AFAIU, _getStdioHandleType returns "terminal" everytime the stream is attached to a character device:

    if (S_ISCHR(buf.st_mode)) return kTerminal;

I don't really understand POSIX, but I don't think that when S_ISCHR() is true, isatty() is also true. I'll leave the decision up to you.

Added this to the Later milestone.

Lack of this is feature appears to be at the root of some ugly output when I invoke the web ui compiler from the editor.

In the editor, if I run build.dart manually (ie, I click "run") for a web ui app, I get the following:

dart --enable-checked-mode build.dart

Total time spent on web/books.html -- �[32m239 ms�[0m

The web ui compiler is coloring its output, which is nice on terminals, but is not nice elsewhere. It would be great for the compiler to know whether it's in a terminal or not.

Any chance of getting this soonish?

Added Started label.

Fixed in https://code.google.com/p/dart/source/detail?r=16839.

Added Fixed label.

Removed Area-IO label.
Added Area-Library, Library-IO labels.