Uri.removeFragment() corrupts URIs #24593
Assignees
Labels
area-core-library
SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries.
library-core
Comments
nex3
added
Type-Defect
area-core-library
lrhn
added a commit
that referenced
this issue
Oct 15, 2015
It used the external getters for the existing port and query, which are non-null even when the port or query are absent. This introduced a new default-valued/empty part. Also reordered declarations to have fields > constructors > rest. Fixes issue #24593 BUG= http://dartbug.com/24593 R=asgerf@google.com Review URL: https://codereview.chromium.org/1396973004.
|
Good catch! Fixed. |
lrhn
added a commit
that referenced
this issue
Oct 19, 2015
It used the external getters for the existing port and query, which are non-null even when the port or query are absent. This introduced a new default-valued/empty part. Also reordered declarations to have fields > constructors > rest. Fixes issue #24593 BUG= http://dartbug.com/24593 R=asgerf@google.com Review URL: https://codereview.chromium.org/1396973004.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If I run
Uri.parse("foo:bar#baz").removeFragment().toString(), I get"foo://:0bar?", where I'd just expect"foo:bar". This is particularly problematic for working withdata:URIs, which aren't at all structured like typical hierarchical URIs and whose fragments must be ignored.The text was updated successfully, but these errors were encountered: