Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect setting of checked parameter in spawnURI #23578

Closed
ghost opened this issue Jun 3, 2015 · 4 comments
Closed

Incorrect setting of checked parameter in spawnURI #23578

ghost opened this issue Jun 3, 2015 · 4 comments
Assignees
@iposva-google
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.
Milestone
1.11

Comments

@ghost
Copy link

ghost commented Jun 3, 2015

Test: isolate/checked_test.dart
crashes in x64:
python tools/test.py -ax64 --write-debug-log --write-test-outcome-log --copy-coredumps --vm-options --optimization-counter-threshold=5 --exclude-suite pkg -t60 isolate/checked_test

The VM requires deterministic generation of unoptimized code in order to preserve deopt-ids. Therefore the checked mode must be turned on before any dart code in that isolate has been run. What happens is that RawReceivePortImpl._set_handler is compiled and run before checked mode is set and a sunsequent optimizing pass recompiles RawReceivePortImpl._set_handler in checked mode. Wrong ICData gets assigned to instructions, causing a crash on x64 at least.
@ghost ghost added the area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. label Jun 3, 2015
@ghost ghost assigned lrhn Jun 3, 2015
@ghost
Copy link
Author

ghost commented Jun 3, 2015

CC @iposva-google

@iposva-google iposva-google assigned iposva-google and unassigned lrhn Jun 6, 2015
@iposva-google
Copy link
Contributor

Looking at this I realized that the whole setting of per isolate flags needs a complete revamp. Also we need to change the currently bolted-on strict compilation setting that can be set from the C API.

@iposva-google iposva-google added this to the 1.11 milestone Jun 6, 2015
@iposva-google
Copy link
Contributor

Fixed with https://codereview.chromium.org//1162033005

@sethladd
Copy link
Contributor

sethladd commented Jun 8, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iposva-google iposva-google

Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.
Projects
None yet
Milestone
1.11
Development

No branches or pull requests
3 participants
@sethladd @lrhn @iposva-google