Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

creating new JsObject() from a prototype with constructor arguments is >5x slower than one with no arguments #23514

Closed
jakemac53 opened this issue May 22, 2015 · 3 comments
Closed

creating new JsObject() from a prototype with constructor arguments is >5x slower than one with no arguments #23514

jakemac53 opened this issue May 22, 2015 · 3 comments
Labels
library-js web-dart2js

Comments

@jakemac53
Copy link
Contributor

See https://gist.github.com/jakemac53/41b37117440beb4dc8e2 for a repro
@jakemac53
Copy link
Contributor Author

cc @sigmundch.

@rakudrama
Copy link
Member

Constructor calls pass through generic code for arbitrary arguments.
This could be faster with special cases for small numbers of arguments.

Added Library-JS, Triaged labels.

@sigmundch
Copy link
Member

@rakudrama improved perf for up to 4 args in 4b2d237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
library-js web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevmoo @jakemac53 @sigmundch @rakudrama