Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pub.dartlang.org documentation link for Sky project is 404 #23402

Closed
DanTup opened this issue May 6, 2015 · 2 comments
Closed

pub.dartlang.org documentation link for Sky project is 404 #23402

DanTup opened this issue May 6, 2015 · 2 comments
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue

Comments

@DanTup
Copy link
Collaborator

DanTup commented May 6, 2015

When I click the documentation link in the right bar here:

https://pub.dartlang.org/packages/sky

I get a 404 (http://www.dartdocs.org/documentation/sky/0.0.5+dart-summit-7/index.html#sky). There's a link to the build failure for Sky, which reports things like:

Error: Library not found 'dart:mojo.internal'.
import 'dart:mojo.internal';
       ^^^^^^^^^^^^^^^^^^^^

It was suggested on the dart-misc list (https://groups.google.com/a/dartlang.org/d/topic/misc/jmr1OF_lbv8/discussion) that this might be complicated VM-stuff or native-extensions related.

Although Sky is early in development; it'd be a shame if this can't be made to work long-term (a Google-authored package hosted by Google with broken docs links). I hope it's fixable!
@lrhn
Copy link
Member

lrhn commented May 7, 2015

I guess the DartDoc tool could be made more resilient against wrong imports.
If the import is not there (including dart: imports), it should just continue anyway.
It could make some references to types or members also invalid, if they refer to types in the missing library, but that's something the analyzer should catch, not DartDoc.

If that's already the case, and the problem is not in dartdocgen, the problem may be in the way pub is calling it instead.

Added Pkg-DocGen, Triaged labels.

@sethladd
Copy link
Contributor

sethladd commented May 7, 2015

Thanks for the report. Once https://code.google.com/p/dart/issues/detail?id=23393 then this issue will fix itself.

The issue is indeed that some packages in pub are calling custom embedding code with custom libraries. We need a way to teach out tools about those custom dart: libraries. That is what https://code.google.com/p/dart/issues/detail?id=23393 is all about.

I'm going to close this issue, however the status of WontFix doesn't capture the intent and is probably misleading. We will fix it, but in a round-about way.

Added WontFix label.

@kevmoo kevmoo added closed-not-planned Closed as we don't intend to take action on the reported issue and removed priority-unassigned labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sethladd @kevmoo @DanTup @lrhn