Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Groups in tests with spaces in their name always pass, no matter what #23156

Closed
alan-knight opened this issue Apr 9, 2015 · 6 comments
Closed

Groups in tests with spaces in their name always pass, no matter what #23156

alan-knight opened this issue Apr 9, 2015 · 6 comments
Assignees
@whesse
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. P1 A high priority bug; for example, a single project is unusable or has many test failures

Comments

@alan-knight
Copy link
Contributor

See also dart-lang/test#61 , but I suspect the problem is at least partially in test.py

So I can write a program like the attached foo_test, put it in dart/tests/html/foo_test.dart and run it with

     tools/test.py -m release -c dart2js -r chrome -j 1 html/foo_test

and get one pass and one fail. This is causing real false passes in our repo, e.g. a number of the groups in node_validator_test had spaces in the names, so we weren't actually properly testing HTML sanitization. It would be good if this either worked or was an error. I will try and track down any other tests in HTML that have this property.

Attachment:
foo_test.dart (426 Bytes)
@alan-knight
Copy link
Contributor Author

There seems to be something more to it, because I'm not seeing this effect on other things that have the described symptoms, e.g. html/custom/entered_left_view_test , but it definitely happens with my example, and with node_validator_test.dart

@ricowind
Copy link
Contributor

Set owner to @whesse.

@whesse
Copy link
Contributor

whesse commented Apr 10, 2015

Proposed a fix in pkg:test upstream. When that is accepted, roll our version of pkg:test, and that will fix it.

Added Waiting label.

@kevmoo
Copy link
Member

kevmoo commented May 7, 2015

https://codereview.chromium.org/1128383002/

Added Started label.

@alan-knight alan-knight added Type-Defect P1 A high priority bug; for example, a single project is unusable or has many test failures area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. labels May 7, 2015
@ricowind
Copy link
Contributor

did this get rolled in?

@kevmoo
Copy link
Member

kevmoo commented Jun 12, 2015

Yup! dart-lang/test@e11f429

@kevmoo kevmoo closed this as completed Jun 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whesse whesse

Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevmoo @alan-knight @whesse @ricowind