Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make window.frames sane. #2312

Closed
vsmenon opened this issue Mar 26, 2012 · 6 comments
Closed

Make window.frames sane. #2312

vsmenon opened this issue Mar 26, 2012 · 6 comments
Assignees
@vsmenon
Labels
web-libraries Issues impacting dart:html, etc., libraries
Milestone
M1

Comments

@vsmenon
Copy link
Member

vsmenon commented Mar 26, 2012

Currently window.frames simply returns the window. In JS, the window object acts as a list: e.g., window.frames[0] returns the first subframe - as does window[0].

This appears to be standard behavior:

https://developer.mozilla.org/en/DOM/window.frames

In Dart, we do not support indexed access on window. We can either add this to window or have window.frames return a list. The latter feels cleaner to me.

Thoughts?
@DartBot
Copy link

DartBot commented Mar 27, 2012

This comment was originally written by antonm@google.com

I vote for window.frames implementing list.

@vsmenon
Copy link
Member Author

vsmenon commented Apr 13, 2012

Removed Area-UI label.
Added Area-DOM label.

@vsmenon
Copy link
Member Author

vsmenon commented Jul 12, 2012

Set owner to @vsmenon.
Added this to the M1 milestone.

@iposva-google
Copy link
Contributor

Removed Area-DOM label.
Added Area-HTML label.

@vsmenon
Copy link
Member Author

vsmenon commented Oct 5, 2012

After discussing with Pete, we decided to remove this API. It's a dated API on the JS sides, and it's been broken for a while in Dart with no complaint. It can also be worked around via queryAll for common cases.

See 1928 for a separate bug requesting this as an enhancement.

I will remove the broken frames and close this bug.

@vsmenon
Copy link
Member Author

vsmenon commented Oct 5, 2012

Deprecated methods removed in 13305.

Added Fixed label.

@vsmenon vsmenon added Type-Defect web-libraries Issues impacting dart:html, etc., libraries labels Oct 5, 2012
@vsmenon vsmenon self-assigned this Oct 5, 2012
@vsmenon vsmenon added this to the M1 milestone Oct 5, 2012
@mkustermann mkustermann mentioned this issue Jun 3, 2015
Open
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsmenon vsmenon

Labels
web-libraries Issues impacting dart:html, etc., libraries
Projects
None yet
Milestone
M1
Development

No branches or pull requests
3 participants
@vsmenon @iposva-google @DartBot