Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regression at r43869 #22495

Closed
rakudrama opened this issue Feb 19, 2015 · 5 comments
Closed

Performance regression at r43869 #22495

rakudrama opened this issue Feb 19, 2015 · 5 comments
Assignees
Labels
P0 A serious issue requiring immediate resolution web-dart2js
Milestone

Comments

@rakudrama
Copy link
Member

DeltaBlue -46%
I have no idea at this point how this CL causes the regression.

@ghost
Copy link

ghost commented Feb 20, 2015

Removed this from the 1.9 milestone.
Added this to the 1.10 milestone.
Added Accepted label.

@ghost
Copy link

ghost commented Feb 20, 2015

This is due to additional runtime type information being set. I am not sure why this is triggered just by using an enum.


Set owner to @karlklose.
Removed this from the 1.10 milestone.
Added this to the 1.9 milestone.

@karlklose
Copy link
Contributor

Added Started label.

@karlklose
Copy link
Contributor

The current implementation of enums uses a factory constructor which may instantiate a Map implementation taht uses the default validKey implementation, and the default implementation checks against the list's type arguments.

Dart2js does not track is-checks depending on the class they appear, so it sets runtime type information on maps.

I am working on changing the implementation of constant maps to avoid this.

@karlklose
Copy link
Contributor

Reason for regression fixed in r45983 and r44019. The change in r43869 has been reapplied in r44020 without regression.


Added Fixed label.

@rakudrama rakudrama added Type-Defect P0 A serious issue requiring immediate resolution web-dart2js labels Feb 25, 2015
@rakudrama rakudrama added this to the 1.9 milestone Feb 25, 2015
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 A serious issue requiring immediate resolution web-dart2js
Projects
None yet
Development

No branches or pull requests

2 participants