Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code_transformers dartSdkDirectory not working properly when SDK installed as Debian package #21225

Closed
DartBot opened this issue Oct 3, 2014 · 14 comments
Closed

code_transformers dartSdkDirectory not working properly when SDK installed as Debian package #21225

DartBot opened this issue Oct 3, 2014 · 14 comments
Assignees
@sigmundch
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams.

Comments

@DartBot
Copy link

DartBot commented Oct 3, 2014

This issue was originally filed by smeagol7...@gmail.com

What steps will reproduce the problem?

  1. Install Dart SDK with Debian (deb) package
  2. call dartSdkDirectory method and it returns null

What is the expected output? What do you see instead?
Expected to see /usr/lib/dart as result, but receives null

What version of the product are you using?
Dart VM version: 1.6.0 (Tue Aug 26 13:49:30 2014) on "linux_x64"

On what operating system?
Debian linux (Jessie)

Please provide any additional information below.
The issue is that debian package is installed into the path /usr/lib/dart, but code in dartSdkDirectory detects the dart SDK by dart-sdk subdir. So I see two possible solutions, modify dartSdkDirectory function to detect sdk dir with some more advanced algorithm, or deply dart sdk in Debian package to the /usr/lib/dart-sdk folder.
@kasperl
Copy link

kasperl commented Oct 8, 2014

cc @blois.
Added Area-Pkg, Pkg-CodeTransformers, Triaged labels.

@kasperl
Copy link

kasperl commented Oct 8, 2014

Issue #21243 has been merged into this issue.

@DartBot
Copy link
Author

DartBot commented Nov 4, 2014

This comment was originally written by @sethladd

This also seems to affect Dart SDK installs via homebrew on Macs.

@DartBot
Copy link
Author

DartBot commented Nov 4, 2014

This comment was originally written by @sethladd

See also https://github.com/google/stagehand/pull/140

@sethladd
Copy link
Contributor

sethladd commented Nov 6, 2014

See https://github.com/dart-lang/bleeding_edge/blob/master/dart/pkg/code_transformers/lib/src/dart_sdk.dart#L22

@dgrove
Copy link
Contributor

dgrove commented Nov 6, 2014

Bob - would you be willing to take a look at this?

Set owner to @munificent.

@munificent
Copy link
Member

Sure thing.

Removed Priority-Unassigned label.
Added Priority-Medium, Accepted labels.

@sethladd
Copy link
Contributor

sethladd commented Dec 6, 2014

See also https://code.google.com/p/dart/issues/detail?id=21783

and dart-lang/homebrew-dart#18

@DartBot
Copy link
Author

DartBot commented Dec 6, 2014

This comment was originally written by @zoechi

this seems related too

@sethladd
Copy link
Contributor

Set owner to @sigmundch.

@sethladd
Copy link
Contributor

We might be able to close this now?

https://codereview.chromium.org//795433002

@DartBot
Copy link
Author

DartBot commented Dec 11, 2014

This comment was originally written by @zoechi

http://dartbug.com/20376 looks like a dup

@sigmundch
Copy link
Member

I think so - I just published the changes in code_transformers 0.2.3+2

Added Fixed label.

@DartBot DartBot added Type-Defect area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. labels Dec 11, 2014
@DartBot DartBot mentioned this issue Jun 5, 2015
Closed
@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

This issue has been moved to dart-archive/code_transformers#21.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sigmundch sigmundch

Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@sethladd @munificent @sigmundch @dgrove @kasperl @DartBot