Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Importing from HTTP doesn't work on dart2js #20836

Closed
DartBot opened this issue Sep 7, 2014 · 9 comments
Closed

Importing from HTTP doesn't work on dart2js #20836

DartBot opened this issue Sep 7, 2014 · 9 comments
Assignees
@floitschG
Labels
web-dart2js

Comments

@DartBot
Copy link

DartBot commented Sep 7, 2014

This issue was originally filed by @kaendfinger

Code:

import "http://gist.githubusercontent.com/kaendfinger/ef1e933a8b295165f2c2/raw/dayName.dart";

void main() {
  print(dayName(new DateTime.now()));
}

When you try to compile this with dart2js, you get the following error:

test.dart:1:8:
Error: Can't read 'http://gist.githubusercontent.com/kaendfinger/ef1e933a8b295165f2c2/raw/dayName.dart' (Illegal argument(s): Unknown scheme in uri 'http://gist.githubusercontent.com/kaendfinger/ef1e933a8b295165f2c2/raw/dayName.dart').
import "http://gist.githubusercontent.com/kaendfinger/ef1e933a8b295165f2c2/raw/dayName.dart";
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Error: Compilation failed.
@sethladd
Copy link
Contributor

sethladd commented Sep 8, 2014

Note, importing from HTTP works in the VM.

Added Area-Dart2JS, Triaged labels.

@floitschG
Copy link
Contributor

https://codereview.chromium.org/554363002

Set owner to @floitschG.
Added Started label.

@floitschG
Copy link
Contributor

Fixed in r40092.

Added Fixed label.

@DartBot
Copy link
Author

DartBot commented Sep 10, 2014

This comment was originally written by @kaendfinger

Thanks

@DartBot
Copy link
Author

DartBot commented Sep 10, 2014

This comment was originally written by @kaendfinger

floitsch, does this support https too? That issue was fixed last night.

@floitschG
Copy link
Contributor

I don't think so, but a few small tests indicate that it would be extremely easy to add.
Reopening.

Added Triaged label.

@DartBot
Copy link
Author

DartBot commented Sep 10, 2014

This comment was originally written by @kaendfinger

Thanks.

@floitschG
Copy link
Contributor

https://codereview.chromium.org/557383002

Added Started label.

@floitschG
Copy link
Contributor

Fixed in r40149.

Added Fixed label.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@floitschG floitschG

Labels
web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sethladd @kevmoo @floitschG @DartBot