Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polymer linter should log if an element is not importing polymer.html #20538

Closed
kevmoo opened this issue Aug 14, 2014 · 7 comments
Closed

Polymer linter should log if an element is not importing polymer.html #20538

kevmoo opened this issue Aug 14, 2014 · 7 comments
Assignees
@jakemac53

Comments

@kevmoo
Copy link
Member

kevmoo commented Aug 14, 2014

Per discussion w/ jakemac
@sigmundch
Copy link
Member

this is already checked by the linter - is it not shown correctly?

@jakemac53
Copy link
Contributor

Looks like its just not making it through to the logging widget for some reason

Added Started label.

@jakemac53
Copy link
Contributor

Set owner to @jakemac53.

@jakemac53
Copy link
Contributor

Ah, the issue is we are not properly propagating up all errors from the original files, only errors coming from the top level file. When inlining files we need to also add their log warnings to the top level files output.

@jakemac53
Copy link
Contributor

Fixed in r39454

@jakemac53
Copy link
Contributor

Added Fixed label.

@DartBot DartBot mentioned this issue Jun 5, 2015
Closed
@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-archive/polymer-dart#428.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakemac53 jakemac53

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevmoo @jakemac53 @sigmundch @DartBot