Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make polymer's build.dart smarter about entrypoints #20396

Closed
sigmundch opened this issue Aug 6, 2014 · 7 comments
Closed

make polymer's build.dart smarter about entrypoints #20396

sigmundch opened this issue Aug 6, 2014 · 7 comments
Assignees
@jakemac53
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams.

Comments

@sigmundch
Copy link
Member

Now that the information is also in the pubspec.yaml, let's read it from there and not specify it twice.

This should make it very easy to write a build.dart as a single line Dart script:

  export 'package:polymer/builder.dart'
@justinfagnani
Copy link
Contributor

I'd rather get rid of build.dart altogether. Transformers should have a better contract with the analyzer.

@sigmundch
Copy link
Member Author

Agree - that's my long term goal too. This bug is to get one step closer and make build.dart as small as it can be, and get rid of the redundancy we have with the pubspec file until we reach that point.

@jakemac53
Copy link
Contributor

Set owner to @jakemac53.

@DartBot
Copy link

DartBot commented Sep 3, 2014

This comment was originally written by @zoechi

Why is build dart needed anyway. Shouldn't this all be done by the analyzer?

@sigmundch
Copy link
Member Author

The analyzer is not aware of most of the polymer logic, so we use build.dart to show nice error messages in the DartEditor that we discover in our linter. One day we hope the analyzer will allow to have plugins so we can include polymer-specific logic that way.

@jakemac53
Copy link
Contributor

Fixed in r40286

Added Fixed label.

@sigmundch sigmundch added Type-Defect area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. labels Sep 15, 2014
@DartBot DartBot mentioned this issue Jun 5, 2015
Closed
@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-archive/polymer-dart#458.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakemac53 jakemac53

Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@justinfagnani @jakemac53 @sigmundch @DartBot