Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please merge CL 330123004 to fix Pub installs within hidden directories #19406

Closed
nex3 opened this issue Jun 12, 2014 · 8 comments
Closed

Please merge CL 330123004 to fix Pub installs within hidden directories #19406

nex3 opened this issue Jun 12, 2014 · 8 comments
Assignees
@ricowind
Labels
merge-to-dev type-task
Milestone
1.5

Comments

@nex3
Copy link
Member

nex3 commented Jun 12, 2014

In order to support the in-development versions of barback, pub's version constraint on barback was expanded to "<0.14.2". However, the version of pub currently in the 1.5 branch doesn't actually support all the features of barback 0.14.1, so its constraint needs to be narrowed again before release.

CL 330123004 contains the patch to merge. Ideally this patch wouldn't be applied to bleeding_edge, since the wider version range is now appropriate there.
@nex3
Copy link
Member Author

nex3 commented Jun 12, 2014

Link: https://codereview.chromium.org//330123004

@kasperl
Copy link

kasperl commented Jun 12, 2014

If you're not going to land the patch on bleeding_edge, it might make sense to make sure the CL is patch against trunk. Is it correct to assume that this change is a no-op for now -- but that it allows you to release barback 0.14.1 without breaking trunk builds?

Added Triaged label.

@nex3
Copy link
Member Author

nex3 commented Jun 12, 2014

If you're not going to land the patch on bleeding_edge, it might make sense to make sure the CL is patch against trunk.

I don't know how to do that -_-. Since the patch is only one character, though, hopefully it won't be too hard to apply.

Is it correct to assume that this change is a no-op for now -- but that it allows you to release barback 0.14.1 without breaking trunk builds?

Not exactly. The builds should be fine either way, and barback 0.14.1 is already released. What this means is that users of 1.5 won't incorrectly get barback 0.14.1 when they run "pub get", which in turn means that transformer authors can safely use 0.14.1 features in the future without breaking users on Dart 1.5.

@dgrove
Copy link
Contributor

dgrove commented Jun 12, 2014

@NweiZ - please do create the patch against trunk so that Rico can just apply it.

@nex3
Copy link
Member Author

nex3 commented Jun 12, 2014

https://codereview.chromium.org/336543004

@ricowind
Copy link
Contributor

Fixed in revision 37300

Added Fixed label.

@nex3
Copy link
Member Author

nex3 commented Jun 13, 2014

Thanks, Rico!

@nex3 nex3 added this to the 1.5 milestone Jun 13, 2014
@DartBot DartBot mentioned this issue Jun 5, 2015
Closed
@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/pub#1008.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ricowind ricowind

Labels
merge-to-dev type-task
Projects
None yet
Milestone
1.5
Development

No branches or pull requests
5 participants
@nex3 @dgrove @kasperl @ricowind @DartBot