Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using putImageData on canvas will crash dartium if the data has been modified #18901

Closed
DartBot opened this issue May 20, 2014 · 6 comments
Closed
Assignees

Comments

@DartBot
Copy link

DartBot commented May 20, 2014

This issue was originally filed by this.is.harry....@gmail.com


What steps will reproduce the problem?

  1. Clone repository https://github.com/boustrophedon/dart-canvas-experiments
  2. Run pub serve
  3. Open http://localhost:8081/crash_test/ in dartium
  4. Become sad

What is the expected output? What do you see instead?
Expected output is a canvas with all pixels' rgba values equal to 20. Crashes instead.

What version of the product are you using? On what operating system?
dartium --version produces
Chromium 34.0.1847.0 aura
(build from https://aur.archlinux.org/packages/dartium-bin/)

dart --version produces
Dart VM version: 1.3.6 (Tue Apr 29 12:40:24 2014) on "linux_x64"

I'm using Arch Linux.

Please provide any additional information below.
this is the code that causes the crash. if you comment out lines 22-24 you can observe a memory leak.
https://github.com/boustrophedon/dart-canvas-experiments/blob/master/test/crash_test/main.dart

related bugs:
https://code.google.com/p/dart/issues/detail?id=11815
https://code.google.com/p/dart/issues/detail?id=14742
http://stackoverflow.com/questions/20645310/why-does-this-use-of-getimagedata-leak-memory

@floitschG
Copy link
Contributor

Added Area-Dartium, Triaged labels.

@a-siva
Copy link
Contributor

a-siva commented May 20, 2014

This seems to be related to the issue we were having in
https://code.google.com/p/dart/issues/detail?id=18321
I was able to reproduce the crash in version prior to the fix for 18321 and
after the fix the crash does not happen.


Set owner to @a-siva.
Added Accepted label.

@DartBot
Copy link
Author

DartBot commented May 21, 2014

This comment was originally written by this.is.harry.ster...@gmail.com


The newest dev channel releases of dartium do indeed fix the crash for me, but the memory leak is still there. Should I report a different bug for that?

@a-siva
Copy link
Contributor

a-siva commented May 21, 2014

I am looking into the memory leak issue, I will use this bug for that.

@a-siva
Copy link
Contributor

a-siva commented May 21, 2014

https://codereview.chromium.org/298723008/ should fix the memory leak issue.
We will now trigger a full GC and that should cleanup stuff.

I have run your test for more than 4 hours now and monitored 'About Memory' the
usage goes up and then a GC happens bringing the usage back down.

@a-siva
Copy link
Contributor

a-siva commented May 22, 2014

Added Fixed label.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants