Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

angular tests should not be against repository packages #18733

Closed
jmesserly opened this issue May 8, 2014 · 2 comments
Closed

angular tests should not be against repository packages #18733

jmesserly opened this issue May 8, 2014 · 2 comments
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).

Comments

@jmesserly
Copy link

see here:

http://build.chromium.org/p/client.dart/builders/pub-mac-debug-be/builds/267/steps/pub%20tests/logs/stdio

I made an intentional change to remove a deprecated "tagName" property from html5lib's Node. This should not break anything. It should use the version of html5lib that is specified in Angular's pubspec.yaml file, which will still have tagName.
@jmesserly
Copy link
Author

analyzer tests too: http://build.chromium.org/p/client.dart/builders/new_analyzer-linux-release-be/builds/6892/steps/tests/logs/stdio

@jmesserly jmesserly added Type-Defect area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). labels May 8, 2014
@jmesserly
Copy link
Author

assuming stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevmoo @jmesserly