Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate appropriate packages/ paths for entrypoints nested within web/ or example/ #17596

Closed
sigmundch opened this issue Mar 18, 2014 · 20 comments
Assignees
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. P1 A high priority bug; for example, a single project is unusable or has many test failures

Comments

@sigmundch
Copy link
Member

Our code generation logic assumes that there is a packages/ folder next to the entrypoint. But pub-build will only have one next to the top-level folder (web/ or example/).

Code generated in example/a/b/c.html, should have references to the polyfills like this:

<html><head>
<script src="../../packages/shadow_dom/shadow_dom.debug.js"></script>
<script src="../../packages/custom_element/custom-elements.debug.js"></script>
<script src="../../packages/browser/interop.js"></script>

@sigmundch
Copy link
Member Author

Added 1.5 label.

@sigmundch
Copy link
Member Author

Added this to the 1.5 milestone.
Removed 1.5 label.

@sigmundch
Copy link
Member Author

Removed this from the 1.5 milestone.
Added this to the Polymer0.10 milestone.

@sigmundch
Copy link
Member Author

This requires also a fix in code_transformers/lib/assets.dart and how we allow resolving packages.

@DartBot
Copy link

DartBot commented May 22, 2014

This comment was originally written by robert.w.ha...@gmail.com


I experienced this as well. But for me there was a packages ordner with just the "browser"-package in it, but nothing else. Cool this might get fixed soon! :) I had the problem with using the polymer package.

@jmesserly
Copy link

Added Pkg-Polymer label.

@jmesserly
Copy link

Removed Pkg-Polymer label.
Added Pkg-PolymerBuild label.

@jmesserly
Copy link

Removed Library-PolymerBuild label.

@jmesserly
Copy link

Removed Area-Polymer label.
Added Area-Pkg label.

@kasperl
Copy link

kasperl commented Jun 4, 2014

Removed this from the Polymer0.10 milestone.
Added this to the 1.6 milestone.

@sethladd
Copy link
Contributor

Customer request to address in the 1.6 build. Happy to provide more context. Thanks!


Removed Priority-Medium label.
Added Priority-High, C8 labels.

@DartBot
Copy link

DartBot commented Jun 20, 2014

This comment was originally written by @zoechi


I think this is also related to https://code.google.com/p/dart/issues/detail?id=16947

@justinfagnani
Copy link
Contributor

Removed C8 label.
Added C7 label.

@sigmundch
Copy link
Member Author

Added C8 label.

@sigmundch
Copy link
Member Author

Removed this from the 1.6 milestone.
Added Polymer-P-1 label.

@sigmundch
Copy link
Member Author

Removed Polymer-P-1 label.
Added Polymer-Milestone-Next label.

@sigmundch
Copy link
Member Author

Added PolymerMilestone-Next label.

@sigmundch
Copy link
Member Author

Removed Polymer-Milestone-Next label.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Added this to the 1.6 milestone.

@sigmundch sigmundch added Type-Defect P1 A high priority bug; for example, a single project is unusable or has many test failures area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. labels Jul 10, 2014
@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-archive/polymer-dart#381.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Development

No branches or pull requests

7 participants