Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of DART_SDK in pub #15019

Closed
munificent opened this issue Nov 11, 2013 · 6 comments
Closed

Get rid of DART_SDK in pub #15019

munificent opened this issue Nov 11, 2013 · 6 comments
Assignees
Labels
type-enhancement A request for a change that isn't a bug

Comments

@munificent
Copy link
Member

Pub uses that environment variable just for a couple of pub tests so that we can make sure we can parse VERSION files correctly.

If an end user sets it, though, it is very unlikely to do what they want. We should remove it entirely (and come up with a different way to test that parsing code), or at least rename it to something more specific.

@munificent
Copy link
Member Author

Added Started label.

@munificent
Copy link
Member Author

Added Fixed label.

@DanTup
Copy link
Collaborator

DanTup commented Oct 16, 2014

I'm using this variable in DartVS s a way to find the SDK; it was nice that you'd already been using it!

In the next version, we'll automatically download and unzip the latest SDK if it's not set, but this variable remains as a way to override that (eg. to use Dev Channel or an old version).

Are users going to be educated that they shouldn't ever set this; or does our use if it seem like a valid way of achieving what we want?

@DartBot
Copy link

DartBot commented Oct 16, 2014

This comment was originally written by @zoechi


see also the discussion at SO http://stackoverflow.com/questions/26408682

@munificent
Copy link
Member Author

This bug is specific to pub's use of DART_SDK. Pub used to require and read that even though pub itself is in the SDK. Now, pub just looks in the directory containing itself to find the SDK so it doesn't need this.

This doesn't mean users can't set a DART_SDK environment variable and use it. It's just that pub itself doesn't need it anymore.

@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/pub#715.

@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed priority-unassigned labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

4 participants