Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DART_SDK and PATH env var mods can cause Dart Editor samples to fail #14967

Closed
danrubel opened this issue Nov 8, 2013 · 5 comments
Closed

DART_SDK and PATH env var mods can cause Dart Editor samples to fail #14967

danrubel opened this issue Nov 8, 2013 · 5 comments
Assignees
@danrubel
Labels
type-enhancement A request for a change that isn't a bug
Milestone
1.1

Comments

@danrubel
Copy link

danrubel commented Nov 8, 2013

If the user has set DART_SDK and it points to a different version of the sdk than Dart Editor provides, then Dart Editor does not work as expected. Tools in the SDK such as pub build stop working as expected. I suspect that problems can also arise if an older SDK is in the PATH env var as well. I had both mods and the DartEditor samples were not working. Removed the mods and all was well.

Since we specifically recommend users set DART_SDK and PATH in the sdk docs (https://www.dartlang.org/tools/sdk/), then Dart Editor should detect this situation on startup and warn the user.
@DartBot
Copy link

DartBot commented Nov 11, 2013

This comment was originally written by LukeEChurch...@gmail.com

Here's a straw-man message:

"Analyser(/Editor) cannot find a version of the Dart SDK it can work with. This is needed for analysis.

Analyser looked in the following places:
   XXX
   XXX (SDK found, but version was blah, not blag)

[Insert any other mitigation strategies here]

Please try reinstalling SDK/Editor from www.dartlang.org.

If everything else fails, please file a defect at www.dartbug.com including the following information.

[Anything else you want to know....]

cc @bwilkerson.
cc @peter-ahe-google.

@danrubel
Copy link
Author

Warn if DART_SDK does not match Editor's notion of an SDK
https://codereview.chromium.org/73603002/

cc @lukechurch.
Added Started label.

@clayberg
Copy link

Removed this from the M9 milestone.
Added this to the 1.1 milestone.

@danrubel
Copy link
Author

Remove all references to DART_SDK now that no other tools reference it.
https://codereview.chromium.org/74223002

@danrubel
Copy link
Author

Added Fixed label.

@danrubel danrubel self-assigned this Nov 15, 2013
@danrubel danrubel added this to the 1.1 milestone Nov 15, 2013
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danrubel danrubel

Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
4 participants
@kevmoo @danrubel @clayberg @DartBot