Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dart repl autocomplete suggests bogus fields with @ in the name #14892

Closed
trinarytree opened this issue Nov 7, 2013 · 5 comments
Closed

dart repl autocomplete suggests bogus fields with @ in the name #14892

trinarytree opened this issue Nov 7, 2013 · 5 comments
Assignees

Comments

@trinarytree
Copy link

i don't know a very small program that will make this happen, but for me, when i type _computedSchema, which is an instance variable at a particular breakpoint, it will autocomplete for me with exactly these 2 suggestions:
(1) _computedSchema@0x144b8438
(2) _computedSchemaFuture@0x144b8438
i hit enter and it says
"'': Error: line 2 pos 22: ')' expected
_computedSchemaFuture@0x144b8438
                     ^"

which kind of sounds like it's saying
"remember my suggestion? yeah, even i don't understand what i meant!"
on the other hand, if i type _computedSchema and hit escape and then hit enter, it admits that _computedSchema existed all along. i can also get the autocomplete to work correctly if i type this._computedSchema.

i want
(a) the repl to give me only suggestions that it will understand.
(b) the repl to give me every suggestion that it will understand.

chromium version 31.0.1650.0 (224845)
Dart VM version: 0.8.7.0_r29341 (Mon Oct 28 02:00:50 2013) on "linux_x64"

@anders-sandholm
Copy link
Contributor

Added Area-Dartium, Triaged labels.

@rmacnak-google
Copy link
Contributor

Sounds like the VM API functions are leaking mangled names.


Set owner to @rmacnak-google.
Added Accepted label.

@rmacnak-google
Copy link
Contributor

Fixed in r30436.


Added Fixed label.

@rmacnak-google
Copy link
Contributor

Reverted previous fix. We want the embedder to be responsible for the demangling.


Added Started label.

@rmacnak-google
Copy link
Contributor

Mangling issue fixed in https://codereview.chromium.org/300393002, but note there is a regression where we aren't getting Dart completions at breakpoints (Issue #19785).


Added Fixed label.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants