Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pub build - expose other folders, not just web #14673

Closed
sigmundch opened this issue Oct 31, 2013 · 19 comments
Closed

pub build - expose other folders, not just web #14673

sigmundch opened this issue Oct 31, 2013 · 19 comments
Assignees
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures type-enhancement A request for a change that isn't a bug
Milestone

Comments

@sigmundch
Copy link
Member

pub build currently will create a 'build/' folder that contains whatever is under 'web/'.

I was wondering if we should make the 'web/' folder explicit, so we can later make room to add 'example/' and 'app/' as other folders generated under 'build/'.

@DartBot
Copy link

DartBot commented Nov 4, 2013

This comment was originally written by Erik.G...@gmail.com


If I understand Sigmund's issue correctly, this would be useful for people making packages of polymer elements. For example, the polymer-elements library (https://github.com/Polymer/polymer-elements), is a collection of polymer elements with an entry point in example for each element. Also, what if I want to transform and run unit tests in javascript against the javascript version of the code?

@sethladd
Copy link
Contributor

I'd love pub build to work with example/ and bin/ (for server-side apps, the build process is a bit different I presume, but creating a snapshot is a good first step)

@nex3
Copy link
Member

nex3 commented Dec 10, 2013

I don't think we're likely to want to use "pub build" with example folders or tests; those seem like a better fit with "pub serve", since they don't need to be deployed anywhere.

That leaves "web" and "bin". Most apps aren't going to have both of these directories, so I don't really want to optimize the directory layout for all apps to handle the few apps that do. Maybe once we start supporting server-side building we can split up the subdirectories in that case in particular, though.

@DartBot
Copy link

DartBot commented Dec 10, 2013

This comment was originally written by @zoechi


Actually I want to publish the examples of my libraries on i.e. Github pages so people can check them out without setting something up by themselves just to see if it contains what they are looking for (polymer elements).

@munificent
Copy link
Member

Removed Type-Defect label.
Added Type-Enhancement label.

@sigmundch
Copy link
Member Author

Issue #11386 has been merged into this issue.

@DartBot
Copy link

DartBot commented Dec 31, 2013

This comment was originally written by ross.dart....@gmail.com


I want to build the example/ for library packages to deploy on github pages and I want to build the test/ for library packages so that I might (easily) test the compiled javascript test application (html tests) on drone.io w/ content_shell

@keertip
Copy link
Contributor

keertip commented Jan 3, 2014

Marked this as blocking #13591.

@munificent
Copy link
Member

Removed Priority-Unassigned label.
Added Priority-High label.

@munificent
Copy link
Member

Marked this as blocking #15829.

@munificent
Copy link
Member

Set owner to @munificent.
Added Accepted label.

@nex3
Copy link
Member

nex3 commented Jan 10, 2014

For reference, this is the current plan for this behavior: https://gist.github.com/munificent/8360674

@munificent
Copy link
Member

Added Started label.

@nex3
Copy link
Member

nex3 commented Jan 27, 2014

Issue #16304 has been merged into this issue.

@sethladd
Copy link
Contributor

Looks like the code was committed. Awesome!


Added this to the 1.2 milestone.

@sethladd
Copy link
Contributor

@munificent
Copy link
Member

Added Fixed label.

@DartBot
Copy link

DartBot commented Jan 31, 2014

This comment was originally written by dev...@futureperfect.info


great news!

@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/pub#695.

@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

7 participants