Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

language/type_promotion_parameter_test/53 #14363

Closed
scheglov opened this issue Oct 23, 2013 · 7 comments
Closed

language/type_promotion_parameter_test/53 #14363

scheglov opened this issue Oct 23, 2013 · 7 comments
Assignees
Milestone

Comments

@scheglov
Copy link
Contributor

  "if ((a is B))" has the same effect as "if (a is B)", so no static warning expected.

@johnniwinther
Copy link
Member

@gbracha: This seems to depend upon the interpretation of the spec's use of 'v is T'; is it denoting concrete syntax (if so 'v is T' is different from '(v is T)') or abstract syntax (in which case 'v is T' is the same as '(v is T)')?


cc @gbracha.

@johnniwinther
Copy link
Member

In the case of 'v is T' denoting abstract syntax, should we also promote '(v) is T'?

@johnniwinther
Copy link
Member

Issue #14747 has been merged into this issue.

@scheglov
Copy link
Contributor Author

scheglov commented Nov 4, 2013

Support for '(v) is T' in analyzer.

https://codereview.chromium.org/47513022

@gbracha
Copy link
Contributor

gbracha commented Nov 4, 2013

I think we want to promote all parenthesized variations

@johnniwinther
Copy link
Member

Set owner to @johnniwinther.
Added Started label.

@johnniwinther
Copy link
Member

Fixed by https://codereview.chromium.org/85633002/


Added Fixed label.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants