Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DocumentFragment.queryAll() does not return ElementList #14015

Closed
DartBot opened this issue Oct 11, 2013 · 3 comments
Closed

DocumentFragment.queryAll() does not return ElementList #14015

DartBot opened this issue Oct 11, 2013 · 3 comments
Assignees
Labels
web-libraries Issues impacting dart:html, etc., libraries
Milestone

Comments

@DartBot
Copy link

DartBot commented Oct 11, 2013

This issue was originally filed by @butlermatt


A recent update to the Element class made Element.queryAll() return an ElementList [1]. However DocumentFragment has not been updated to have it's version of queryAll() do the same. DocumentFragment.queryAll() currently returns a List<Element> as per the old way.

This causes warnings in the editor when using shadowRoot.queryAll(..)[3] when trying to modify classes as such:
shadowRoot.queryAll(..).classes.add('..');

@kasperl
Copy link

kasperl commented Oct 14, 2013

Added Area-HTML, Triaged labels.

@efortuna
Copy link
Contributor

Set owner to @efortuna.
Added this to the M8 milestone.

@efortuna
Copy link
Contributor

FIxed as of https://codereview.chromium.org//27223003


Added Fixed label.

@DartBot DartBot added Type-Defect web-libraries Issues impacting dart:html, etc., libraries labels Oct 16, 2013
@DartBot DartBot added this to the M8 milestone Oct 16, 2013
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
web-libraries Issues impacting dart:html, etc., libraries
Projects
None yet
Development

No branches or pull requests

4 participants