Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hint if there are imports dart:mirrors without @SymbolsUsed #12297

Closed
peter-ahe-google opened this issue Aug 7, 2013 · 5 comments
Closed

Hint if there are imports dart:mirrors without @SymbolsUsed #12297

peter-ahe-google opened this issue Aug 7, 2013 · 5 comments
Assignees
@peter-ahe-google
Labels
library-mirrors type-enhancement A request for a change that isn't a bug web-dart2js
Milestone
M8

Comments

@peter-ahe-google
Copy link
Contributor

If dart2js turns of tree-shaking, the size of the code blows up unless the user has specified @­SymbolsUsed.

In that case, dart2js should hint on all imports of dart:mirrors.
@kasperl
Copy link

kasperl commented Sep 18, 2013

Added this to the M7 milestone.

@kasperl
Copy link

kasperl commented Sep 23, 2013

Do you consider this fixed, Peter?

@kasperl
Copy link

kasperl commented Sep 30, 2013

Removed Priority-Unassigned label.
Added Priority-Medium label.

@kasperl
Copy link

kasperl commented Oct 2, 2013

Removed this from the M7 milestone.
Added this to the M8 milestone.

@peter-ahe-google
Copy link
Contributor Author

I implemented something like this.

Added Fixed label.

@peter-ahe-google peter-ahe-google self-assigned this Oct 8, 2013
@peter-ahe-google peter-ahe-google added this to the M8 milestone Oct 8, 2013
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peter-ahe-google peter-ahe-google

Labels
library-mirrors type-enhancement A request for a change that isn't a bug web-dart2js
Projects
None yet
Milestone
M8
Development

No branches or pull requests
3 participants
@kevmoo @kasperl @peter-ahe-google