Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure source_maps can read source maps generated by dart2js #11782

Closed
sigmundch opened this issue Jul 11, 2013 · 5 comments
Closed

ensure source_maps can read source maps generated by dart2js #11782

sigmundch opened this issue Jul 11, 2013 · 5 comments
Assignees
@sigmundch
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. pkg-sourcemaps

Comments

@sigmundch
Copy link
Member

It seems that simply reading the file generated by dart2js fails because the 'file' key is missing, and otherwise we don't seem to find the correct target entry corresponding to a location.
@sigmundch
Copy link
Member Author

Turns out there was a bug in the source_map parser: entries that have only a column marker were parsed incorrectly.

We weren't hitting this bug before because the source map builder did not use this optimization part of the encoding. It now does.

Fix available here: https://codereview.chromium.org/19019006/

@sigmundch
Copy link
Member Author

Added Fixed label.

@sigmundch
Copy link
Member Author

Added Library-SourceMaps label.

@anders-sandholm
Copy link
Contributor

Removed Library-SourceMaps label.
Added Pkg-SourceMaps label.

@sigmundch sigmundch added Type-Defect area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. pkg-sourcemaps labels Feb 6, 2014
@sigmundch sigmundch self-assigned this Feb 6, 2014
@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/source_maps#4.

@DartBot DartBot mentioned this issue Jun 5, 2015
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sigmundch sigmundch

Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. pkg-sourcemaps
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sigmundch @anders-sandholm @DartBot